Extract former CXXMappings into TypeNames struct #838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeonMatthesKDAB
force-pushed
the
835-naming-phase
branch
2 times, most recently
from
bda5dbf to
82a7341
Compare
|
Information for the reviewer: |
LeonMatthesKDAB
force-pushed
the
835-naming-phase
branch
from
82a7341 to
dcfe96c
Compare
ahayzen-kdab
reviewed
Feb 8, 2024
ahayzen-kdab
reviewed
Feb 8, 2024
ahayzen-kdab
approved these changes
Feb 8, 2024
This is the first stage of the Naming phase (KDAB#835) refactor. All associations between types and their fully qualified names are now stored in one central database, the TypeNames struct. The final goal for this struct is to include all fully qualified names for each nameable type in the bridge. Therefore the generator can use this to lookup any references from e.g. arguments. This is not quite done yet, as this isn't yet used everywhere, but it's a good first step
LeonMatthesKDAB
force-pushed
the
835-naming-phase
branch
from
dcfe96c to
31592a2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first stage of the Naming phase (#835) refactor. All associations between types and their fully qualified names are now stored in one central database, the TypeNames struct.
The final goal for this struct is to include all fully qualified names for each nameable type in the bridge.
Therefore the generator can use this to lookup any references from e.g. arguments.
This is not quite done yet, as this isn't yet used everywhere, but it's a good first step