Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fails to build with kddockwidgets-2.0.0: error: no viable conversion from 'const QVector<KDDockWidgets::Core::DockWidget *>' to 'const QVector<KDDockWidgets::DockWidgetBase *>' #569

Closed
yurivict opened this issue Dec 7, 2023 · 1 comment · Fixed by #570
Labels

Comments

@yurivict
Copy link

yurivict commented Dec 7, 2023

Describe the bug

wrkdirs/usr/ports/devel/hotspot/work/hotspot-1.4.1/src/mainwindow.cpp:265:36: error: no viable conversion from 'const QVector<KDDockWidgets::Core::DockWidget *>' to 'const QVector<KDDockWidgets::DockWidgetBase *>'
    m_resultsPage->initDockWidgets(restored);
                                   ^~~~~~~~
/usr/local/include/qt5/QtCore/qvector.h:72:12: note: candidate constructor not viable: no known conversion from 'const Vector<Core::DockWidget *>' (aka 'const QVector<KDDockWidgets::Core::DockWidget *>') to 'const QVector<KDDockWidgets::DockWidgetBase *> &' for 1st argument
    inline QVector(const QVector<T> &v);
           ^
/usr/local/include/qt5/QtCore/qvector.h:75:5: note: candidate constructor not viable: no known conversion from 'const Vector<Core::DockWidget *>' (aka 'const QVector<KDDockWidgets::Core::DockWidget *>') to 'QVector<KDDockWidgets::DockWidgetBase *> &&' for 1st argument
    QVector(QVector<T> &&other) noexcept : d(other.d) { other.d = Data::sharedNull(); }
    ^
/usr/local/include/qt5/QtCore/qvector.h:79:12: note: candidate constructor not viable: no known conversion from 'const Vector<Core::DockWidget *>' (aka 'const QVector<KDDockWidgets::Core::DockWidget *>') to 'std::initializer_list<DockWidgetBase *>' for 1st argument
    inline QVector(std::initializer_list<T> args);
           ^
/usr/local/include/qt5/QtCore/qvector.h:70:14: note: explicit constructor is not a candidate
    explicit QVector(int size);
             ^
/usr/local/include/qt5/QtCore/qvector.h:83:14: note: explicit constructor is not a candidate
    explicit QVector(QArrayDataPointerRef<T> ref) noexcept : d(ref.ptr) {}
             ^
/wrkdirs/usr/ports/devel/hotspot/work/hotspot-1.4.1/src/resultspage.h:55:73: note: passing argument to parameter 'restored' here
    void initDockWidgets(const QVector<KDDockWidgets::DockWidgetBase*>& restored);
                                                                        ^
1 error generated.

Version: 1.4.1
clang-16
FreeBSD 13.2

@yurivict yurivict added the bug label Dec 7, 2023
@milianw
Copy link
Member

milianw commented Dec 7, 2023

Yes, I see that now too with the updated KDDW in archlinux. Seems like we need to fix the code to make it somewhat more compatible with both 1.6+ and 2.x+

lievenhey added a commit that referenced this issue Dec 7, 2023
this patch fixes the compile errors with kddockwidgets 2.0 but keeps
compatibility with earlier versions

fixes: #569
lievenhey added a commit that referenced this issue Dec 11, 2023
this patch fixes the compile errors with kddockwidgets 2.0 but keeps
compatibility with earlier versions

fixes: #569
milianw pushed a commit that referenced this issue Dec 11, 2023
this patch fixes the compile errors with kddockwidgets 2.0 but keeps
compatibility with earlier versions

fixes: #569
lievenhey added a commit that referenced this issue Apr 15, 2024
this patch fixes the compile errors with kddockwidgets 2.0 but keeps
compatibility with earlier versions

fixes: #569
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants