improvements for the disassembler

[lievenhey]

Now the disassembler looks at symbol.actualPath and checks if that file exists (usualy located in .debug)
If the file does not exists it searches in debugPaths and then in extraLibPaths
If none is found it tries symbol.path (original lib file which may not include debug informations)

fixes #450

[milianw]

great stuff, but overall some changes are required

[GitMensch]

Note: If possible it would be nice to have the Dissassembly Window be split, so the sizes of "source" vs. "assembly" can be adjusted. The later often has < 60 characters (at least with C, is that different with C++?), while the code is much wider. As it is now there is often a lot of empty space on the right side while the left has the code elided - and the user seems to not able to adjust these sizes.

[GitMensch]

Nevermind, I've forgot the chmod +x and used an old version. The sliding with the new version works perfectly!
For the search there seems to be something missing in the UI (at least the menu, possibly?) for the search; I think a magnifying glass in the bottom bar which contains the syntax highlighting selection would be ideal.
Using [CTRL]+[F], then up/down buttons work fine (a "case-sensitive" check mark would be nice, though).

[GitMensch]

@milianw: Any chance to re-review?

[lievenhey]

there is now a magnifying glass and a checkbox for a case sensitive search

[GitMensch]

The adjusted search works good. The only missing thing seems to be some visual feedback, maybe just select the line with the result?

[GitMensch]

Other than the "visual feedback" on the search and the minor README notes, I see no open points from a user-perspective.

[milianw]

please write better commit messages

[GitMensch]

Just wondering: would it be more useful to split this PR into multiple parts? It solves multiple issues an it may be faster (or only more work, not sure) to get some implemented/fixed if the number of changes that need to be reviewed are smaller?

[lievenhey]

I removed the search stuff. This should now only contain reviewed code.
I will add the search again in a new PR.

[GitMensch]

Thank you very much!

[GitMensch]

If it isn't possible to re-review the reviewed code / merge that into master - could you please rebase the branch so the resulting appimage has both?

[lievenhey]

done

[GitMensch]

Thank you, the resulting AppImage works fine.

Would it be reasonable to tackle #418 in this PR, too? That issue is about adding settings and use them in the disassembler view.

[lievenhey]

6684819a should already fix that. That commit allows the disassembler to search --debugPaths and --extraLibPaths.

[milianw]

Thank you for your work @lievenhey as always, and sorry for taking so long with this one!

[GitMensch]

Would it be reasonable to tackle #418 in this PR, too? That issue is about adding settings and use them in the disassembler view.

6684819a should already fix that. That commit allows the disassembler to search --debugPaths and --extraLibPaths.

That seems to handle only binaries, from -help:

--extraLibPaths Colon separated list of extra paths to find libraries.

but in any case that's something for another PR now :-)