Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

limit assembly highlighters #567

Merged
merged 1 commit into from
Dec 5, 2023
Merged

limit assembly highlighters #567

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 19 additions & 6 deletions src/resultsdisassemblypage.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -433,16 +433,29 @@ ResultsDisassemblyPage::ResultsDisassemblyPage(CostContextMenu* costContextMenu,
#if KFSyntaxHighlighting_FOUND
QStringList schemes;

const auto definitions = m_repository->definitions();
auto definitions = m_repository->definitions();
schemes.reserve(definitions.size());

std::transform(definitions.begin(), definitions.end(), std::back_inserter(schemes),
[](const auto& definition) { return definition.name(); });

auto definitionModel = new QStringListModel(this);
definitionModel->setStringList(schemes);
auto sourceCodeDefinitionModel = new QStringListModel(this);
sourceCodeDefinitionModel->setStringList(schemes);

auto connectCompletion = [definitionModel, schemes, this](QComboBox* box, auto* model) {
QStringList assemblySchemes = {QStringLiteral("None")};

std::transform(definitions.begin(),
std::partition(definitions.begin(), definitions.end(),
[](const KSyntaxHighlighting::Definition& definition) {
return definition.section() == QStringLiteral("Assembler");
}),
std::back_inserter(assemblySchemes),
[](const KSyntaxHighlighting::Definition& definition) { return definition.name(); });

auto assemblySchemesModel = new QStringListModel(this);
assemblySchemesModel->setStringList(assemblySchemes);

auto connectCompletion = [schemes, this](QStringListModel* definitionModel, QComboBox* box, auto* model) {
auto completer = new QCompleter(this);
completer->setModel(definitionModel);
completer->setCaseSensitivity(Qt::CaseInsensitive);
Expand All @@ -459,8 +472,8 @@ ResultsDisassemblyPage::ResultsDisassemblyPage(CostContextMenu* costContextMenu,
[box](const QString& definition) { box->setCurrentText(definition); });
};

connectCompletion(ui->sourceCodeComboBox, m_sourceCodeModel);
connectCompletion(ui->assemblyComboBox, m_disassemblyModel);
connectCompletion(sourceCodeDefinitionModel, ui->sourceCodeComboBox, m_sourceCodeModel);
connectCompletion(assemblySchemesModel, ui->assemblyComboBox, m_disassemblyModel);
#else
ui->customSourceCodeHighlighting->setVisible(false);
ui->customAssemblyHighlighting->setVisible(false);
Expand Down