Add support for redux-devtools-extension #12
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
August 6, 2016 16:02
… May be it's changed in a recent update. Added regex test to catch both "@@redux/INIT" and "@@init".
…the tests. Added new NPM scripts for running typings and intalling typings 'postinstall'
…people who pull the library
This was referenced Aug 7, 2016
Closed
|
Just noticed some of this work has already been done on the develop branch. I'm pulling the PR back and will reapply smaller PRs to the develop branch. |
|
Thanks for this @tdbrian - looking forward to the new PR. |
|
@tdbrian I've just pushed a few changes to develop, mainly the addition of the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/zalmoxisus/redux-devtools-extension is a very popular extension for Redux but because 'createStore' is not available outside the library for this extension, I went ahead and added support for the debugging extension at the create store. The tests succeeded after changes, and I tested that the extension does indeed work now with this library. Please let me know if you'd like me to make different changes to allow for this support.
Other commits include changing TSD to Typings which is recommended now by the TSD author, adding Store to index.d.ts, adding new scripts to package.json for Typings and running test on Windows, fixing issue where initial Redux action type was not being caught for setting initial state, and fixing typing errors in tests.