Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor to rename binding to annotation #12

Merged
merged 4 commits into from
Jan 29, 2025
Merged

Conversation

ajbalogh
Copy link
Collaborator

Rename any reference of binding to annotation.
Include proto and pyi files in the package distribution.

@ajbalogh ajbalogh self-assigned this Jan 29, 2025
Copy link
Collaborator

@thomas-am thomas-am left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Ricefrog
Copy link
Collaborator

LGTM, but I think the VERSION file needs to be updated

@ajbalogh
Copy link
Collaborator Author

LGTM, but I think the VERSION file needs to be updated

Even though this is a breaking change, since we have not implemented just update the minor field?

@ajbalogh ajbalogh requested a review from Ricefrog January 29, 2025 18:51
@ajbalogh
Copy link
Collaborator Author

ajbalogh commented Jan 29, 2025

Looking at the annotate.proto and possible concerns regarding the Any value (see the serialization test https://github.com/Keysight/infrastructure/pull/12/files#diff-e834f887de9d6131e7f6b2f2a8a50589300012af5baf6771ecd0a75e3c0d2985), should we consider ease of use, create a oneof and include popular datatypes including Any?

oneof {
  string string_value = 10;
  uint32 uint32_value = 11;
  ...
  Any any = 20;
}

@ajbalogh ajbalogh requested a review from jkristia January 29, 2025 18:59
@Ricefrog
Copy link
Collaborator

Even though this is a breaking change, since we have not implemented just update the minor field?

+1 on this

@Ricefrog
Copy link
Collaborator

Looking at the annotate.proto and possible concerns regarding the Any value (see the serialization test https://github.com/Keysight/infrastructure/pull/12/files#diff-e834f887de9d6131e7f6b2f2a8a50589300012af5baf6771ecd0a75e3c0d2985), should we consider ease of use, create a oneof and include popular datatypes including Any?

oneof {
  string string_value = 10;
  uint32 uint32_value = 11;
  ...
  Any any = 20;
}

Need Jesper's input on this. From my point of view it seems redundant to have both Any and a oneof

@thomas-am
Copy link
Collaborator

Looking at the annotate.proto and possible concerns regarding the Any value (see the serialization test https://github.com/Keysight/infrastructure/pull/12/files#diff-e834f887de9d6131e7f6b2f2a8a50589300012af5baf6771ecd0a75e3c0d2985), should we consider ease of use, create a oneof and include popular datatypes including Any?

oneof {
  string string_value = 10;
  uint32 uint32_value = 11;
  ...
  Any any = 20;
}

Need Jesper's input on this. From my point of view it seems redundant to have both Any and a oneof

And oneofs are clunky to use too.

Copy link
Collaborator

@jkristia jkristia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@Ricefrog Ricefrog merged commit 0535907 into main Jan 29, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants