-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor to rename binding to annotation #12
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
LGTM, but I think the VERSION file needs to be updated |
Even though this is a breaking change, since we have not implemented just update the minor field? |
Looking at the annotate.proto and possible concerns regarding the Any value (see the serialization test https://github.com/Keysight/infrastructure/pull/12/files#diff-e834f887de9d6131e7f6b2f2a8a50589300012af5baf6771ecd0a75e3c0d2985), should we consider ease of use, create a oneof and include popular datatypes including Any?
|
+1 on this |
Need Jesper's input on this. From my point of view it seems redundant to have both Any and a oneof |
And oneofs are clunky to use too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me
Rename any reference of binding to annotation.
Include proto and pyi files in the package distribution.