screws_tilt_adjust: add option to compute probe-relative points automatically, as well as raise z at the end #6787
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
screws_tilt_adjust
expects screw points as probe-relative, whilebed_screws
is nozzle-relative. This is a bit silly (and confusing) -- the system's got the probe offsets, it can do the math faster than I can. In order to maintain backwards compat, this adds ause_bed_screws
option toscrews_tilt_adjust
. If it's set (yes
,true
,1
), then the screw positions are read frombed_screws
, and are offset by the probe offset.It can't use the ProbePointsHelper's
use_xy_offsets
, because that may put the points outside of range; it applies the offsets manually, and pushes them within x/y range if they're outside. (It would be nice ifProbePointsHelper
had a "and push points in range" option, maybe also a "skip out of range" option.) Also ran into a weird issue that ifdefault_points
wasn't specified,ProbePointsHelper
suddenly required apoints
config option; didn't investigate why, from my reading of the code it shouldn't be required.This patch also adds a
end_z
option toscrews_tilt_adjust
to give a z to raise the toolhead to after probing the last point. Otherwise it leaves the toolhead right over top of the last screw you may need to modify; you can manually move and run it again, but if we're trying to be helpful...(Also -- why do
bed_screws
andscrews_tilt_adjust
both exist? They're doing 99% the same work, except one uses a probe and gives you turn instructions, both of which could be optional.. e.g. manual probe, and if you don't know screw info, then it can just give you the relative heights.)