Increase phpstan level to 8 #391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexpozzi
force-pushed
the
phpstan-lvl-8
branch
4 times, most recently
from
75d88fc to
49957fe
Compare
nm2107
reviewed
Feb 14, 2020
.php_cs.cache
Outdated
| @@ -0,0 +1 @@ | |||
| {"php":"7.4.2","version":"2.16.1:v2.16.1#c8afb599858876e95e8ebfcd97812d383fa23f02","indent":" ","lineEnding":"\n","rules":{"visibility_required":true,"ternary_to_null_coalescing":true,"encoding":true,"full_opening_tag":true,"blank_line_after_namespace":true,"braces":true,"class_definition":true,"constant_case":true,"elseif":true,"function_declaration":true,"indentation_type":true,"line_ending":true,"lowercase_keywords":true,"method_argument_space":{"on_multiline":"ensure_fully_multiline"},"no_break_comment":true,"no_closing_tag":true,"no_spaces_after_function_name":true,"no_spaces_inside_parenthesis":true,"no_trailing_whitespace":true,"no_trailing_whitespace_in_comment":true,"single_blank_line_at_eof":true,"single_class_element_per_statement":{"elements":["property"]},"single_import_per_statement":true,"single_line_after_imports":true,"switch_case_semicolon_to_colon":true,"switch_case_space":true,"array_indentation":true,"array_syntax":{"syntax":"short"},"align_multiline_comment":{"comment_type":"all_multiline"},"binary_operator_spaces":true,"blank_line_after_opening_tag":true,"blank_line_before_statement":true,"cast_spaces":true,"class_attributes_separation":true,"combine_consecutive_issets":true,"combine_consecutive_unsets":true,"compact_nullable_typehint":true,"concat_space":{"spacing":"one"},"PedroTroller\/exceptions_punctuation":true,"PedroTroller\/line_break_between_method_arguments":{"max-args":10},"PedroTroller\/comment_line_to_phpdoc_block":true,"PedroTroller\/useless_code_after_return":true},"hashes":{"src\/Knp\/Snappy\/AbstractGenerator.php":3020002203,"src\/Knp\/Snappy\/GeneratorInterface.php":3708897097,"src\/Knp\/Snappy\/Image.php":207790329,"src\/Knp\/Snappy\/Pdf.php":2353233392,"src\/Knp\/Snappy\/Exception\/FileAlreadyExistsException.php":1655581840,"tests\/Knp\/Snappy\/AbstractGeneratorTest.php":2344254468,"tests\/Knp\/Snappy\/PdfTest.php":156588972,"tests\/Knp\/Snappy\/ImageTest.php":4066889974}} | |||
There was a problem hiding this comment.
please remove this file from this PR and add it to the .gitignore ;)
There was a problem hiding this comment.
can you add this file to the .gitignore file please ?
There was a problem hiding this comment.
It's not related to this PR, I'm adding the CSFixer on a different PR and it has already been added on .gitignore there 😉
It has erroneously been added during a branch switch 😞
fabschurt
suggested changes
Feb 14, 2020
.php_cs.cache
Outdated
| @@ -0,0 +1 @@ | |||
| {"php":"7.4.2","version":"2.16.1:v2.16.1#c8afb599858876e95e8ebfcd97812d383fa23f02","indent":" ","lineEnding":"\n","rules":{"visibility_required":true,"ternary_to_null_coalescing":true,"encoding":true,"full_opening_tag":true,"blank_line_after_namespace":true,"braces":true,"class_definition":true,"constant_case":true,"elseif":true,"function_declaration":true,"indentation_type":true,"line_ending":true,"lowercase_keywords":true,"method_argument_space":{"on_multiline":"ensure_fully_multiline"},"no_break_comment":true,"no_closing_tag":true,"no_spaces_after_function_name":true,"no_spaces_inside_parenthesis":true,"no_trailing_whitespace":true,"no_trailing_whitespace_in_comment":true,"single_blank_line_at_eof":true,"single_class_element_per_statement":{"elements":["property"]},"single_import_per_statement":true,"single_line_after_imports":true,"switch_case_semicolon_to_colon":true,"switch_case_space":true,"array_indentation":true,"array_syntax":{"syntax":"short"},"align_multiline_comment":{"comment_type":"all_multiline"},"binary_operator_spaces":true,"blank_line_after_opening_tag":true,"blank_line_before_statement":true,"cast_spaces":true,"class_attributes_separation":true,"combine_consecutive_issets":true,"combine_consecutive_unsets":true,"compact_nullable_typehint":true,"concat_space":{"spacing":"one"},"PedroTroller\/exceptions_punctuation":true,"PedroTroller\/line_break_between_method_arguments":{"max-args":10},"PedroTroller\/comment_line_to_phpdoc_block":true,"PedroTroller\/useless_code_after_return":true},"hashes":{"src\/Knp\/Snappy\/AbstractGenerator.php":3020002203,"src\/Knp\/Snappy\/GeneratorInterface.php":3708897097,"src\/Knp\/Snappy\/Image.php":207790329,"src\/Knp\/Snappy\/Pdf.php":2353233392,"src\/Knp\/Snappy\/Exception\/FileAlreadyExistsException.php":1655581840,"tests\/Knp\/Snappy\/AbstractGeneratorTest.php":2344254468,"tests\/Knp\/Snappy\/PdfTest.php":156588972,"tests\/Knp\/Snappy\/ImageTest.php":4066889974}} | |||
There was a problem hiding this comment.
I’m not sure it’s a good idea to commit cache files to the repo 😉 Maybe you can remove it, and add a *.cache rule to the .gitignore file in order to avoid this?
There was a problem hiding this comment.
It's not related to this PR, I'm adding the CSFixer on a different PR and it has already been added on .gitignore there 😉
It has erroneously been added during a branch switch 😞
| $php_executable = $path . DIRECTORY_SEPARATOR . 'php' . (isset($_SERVER['WINDIR']) ? '.exe' : ''); | ||
| if (file_exists($php_executable) && is_file($php_executable)) { | ||
| return $php_executable; | ||
| if (false !== getenv('PATH')) { |
There was a problem hiding this comment.
I generally try to avoid nesting whole blocks of code in a if block (it can hinder readability and increase cyclomatic complexity) if it can be done in another way; here, I think you can use the early return technique:
if (false === getenv('PATH')) {
return null;
}
fabschurt
approved these changes
Feb 14, 2020
alexpozzi
force-pushed
the
phpstan-lvl-8
branch
from
5e04f87 to
15d05f8
Compare
nm2107
approved these changes
Feb 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The error
Parameter #1 $command of class Symfony\Component\Process\Process constructor expects array, string given.has been ignored because theSymfony\Component\Process\Processconstructor is only called with a string as its first parameter on v3.4 (see the condition above) and on that version, calling it with a string it's still supported (that part of the code will be removed when the support for Symfony 3.4 will be removed).