-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated Manga constructors #1499
Remove deprecated Manga constructors #1499
Conversation
I believe it would be better to store authors as
|
@Koitharu not all sources have same capabilities like MangaDex to get id by name for example MangaNato where we can get authors manga with this path |
I would like to merge this feature into master before Kotatsu v8 release so let's keep it string for a while |
Ok then will rebase it to |
Don't rebase and don't worry about conflicts, I'll fix it when merge I believe most manga sources provide some way to obtain author id by name. In all we need an ability to search by author string for global search across multiple sources |
cd7774e
to
8de1dab
Compare
8de1dab
to
e9224db
Compare
e9224db
to
2a5f5bb
Compare
I already rebased)) |
Remove deprecated Manga constructors to make sure
authors
field is propagated andauthor
is derived from it