Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use AUTHENTICATE PLAIN instead of LOGIN #1725

Merged
merged 1 commit into from
Mar 6, 2025

Conversation

przemub
Copy link
Contributor

@przemub przemub commented Mar 6, 2025

Makes imaplib use more modern AUTHENTICATE verb
rather than LOGIN.
The immediate benefit is that now the credentials
can be non-ASCII.
In the future, it may be used to add other
authentication methods, such as OAuth.

References:

Note: This patch was originally created in 2021 against RadicaleIMAP, which has since been integrated to Radicale. Here is the original discussion: Unrud/RadicaleIMAP#7

Makes imaplib use more modern AUTHENTICATE verb
rather than LOGIN.
The immediate benefit is that now the credentials
can be non-ASCII.
In the future, it may be used to add other
authentication methods, such as OAuth.

References:
* https://datatracker.ietf.org/doc/html/rfc6855.html#page-5
* https://bugs.python.org/issue13700
@pbiering pbiering self-assigned this Mar 6, 2025
@pbiering pbiering added this to the 3.5.0 milestone Mar 6, 2025
Copy link
Collaborator

@pbiering pbiering left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@pbiering pbiering merged commit 0fa5021 into Kozea:master Mar 6, 2025
19 checks passed
@przemub
Copy link
Contributor Author

przemub commented Mar 6, 2025

Thanks! Schlafen Sie gut!

pbiering added a commit that referenced this pull request Mar 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants