Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Pushing empty style onto empty stack bleeds color #26

Merged
merged 1 commit into from
Jun 15, 2023

Conversation

rymiel
Copy link
Member

@rymiel rymiel commented Jun 14, 2023

Top level color was set to 0 initially before, and didn't distinguish between the top level and an unset color after popping to the top level

Will address PaperMC/Paper#9343

@rymiel rymiel added the bug Something isn't working label Jun 14, 2023
@rymiel rymiel requested a review from zml2008 June 14, 2023 22:10
@rymiel
Copy link
Member Author

rymiel commented Jun 14, 2023

@zml2008 should i just bump the version in this pr too or what

@zml2008 zml2008 added this to the 1.0.1 milestone Jun 15, 2023
@zml2008 zml2008 added this pull request to the merge queue Jun 15, 2023
Merged via the queue into trunk with commit 66a6c6a Jun 15, 2023
@zml2008 zml2008 deleted the fix-pop-followed-by-empty-push branch June 15, 2023 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants