Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slightly better README.md #122

Merged
merged 3 commits into from
Dec 29, 2022
Merged

Slightly better README.md #122

merged 3 commits into from
Dec 29, 2022

Conversation

MohamedAliRashad
Copy link
Contributor

My take on the simplicity of experiencing the project

@MohamedAliRashad MohamedAliRashad changed the title Main Slightly better README.md Dec 28, 2022
Copy link

@x64x2 x64x2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Address readme before merging

Copy link
Collaborator

@yk yk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you very much. I've just made #123 which might conflict with this one.

while we are improving, do you think you could also remove the period between the first two sentences and add a comma?

@MohamedAliRashad
Copy link
Contributor Author

@yk I fixed what you ask

@yk
Copy link
Collaborator

yk commented Dec 29, 2022

thank you :) now just resolve the merge conflicts then we're perfect

@yk
Copy link
Collaborator

yk commented Dec 29, 2022

Thank you! We don't need the email link thing anymore, but I can remove that later. Small improvements like this really make the experience better for newcomers :)

@yk yk enabled auto-merge December 29, 2022 14:04
@yk yk self-requested a review December 29, 2022 20:40
@yk yk merged commit 665ab86 into LAION-AI:main Dec 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants