Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update eslint config #142

Merged
merged 6 commits into from
Dec 29, 2022
Merged

Update eslint config #142

merged 6 commits into from
Dec 29, 2022

Conversation

AbdBarho
Copy link
Collaborator

@AbdBarho AbdBarho commented Dec 29, 2022

Continuation of #125

Closes #121

Update eslint config & fix all linting errors

We warn instead of error for sort imports, since we can't just eslint --fix.

There are some other tools that can do this, we could integrate them later.

var prisma;
const prisma;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the const here breaks build.

Copy link
Collaborator

@k-nearest-neighbor k-nearest-neighbor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and builds on latest

@k-nearest-neighbor
Copy link
Collaborator

I think you just need to rebase to fix the Header.tsx merge

@k-nearest-neighbor
Copy link
Collaborator

I think you just need to rebase to fix the Header.tsx merge

NM, I resolved it through the github UI

@k-nearest-neighbor k-nearest-neighbor merged commit d0cc4d6 into main Dec 29, 2022
@k-nearest-neighbor k-nearest-neighbor deleted the eslint branch December 29, 2022 18:34
@AbdBarho AbdBarho mentioned this pull request Dec 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add eslint rules for consistent imports
4 participants