Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic redis setup for rate limiting #187

Merged
merged 4 commits into from
Jan 1, 2023

Conversation

GraemeHarris
Copy link
Collaborator

As per #175 redis setup to be used for rate limiting - maybe BE cache down the line.

I have updated the docker compose file to include redis + redis insights. They're quite basic for now with a lot of settings that can be tweaked as per need / feedback.

Ansible changes might need more testing

@yk
Copy link
Collaborator

yk commented Dec 30, 2022

also, some merge conflicts

@GraemeHarris GraemeHarris force-pushed the add-redis-for-rate-limit branch from bdc2129 to 1ec5c43 Compare December 31, 2022 10:51
@yk yk self-requested a review December 31, 2022 14:53
Copy link
Collaborator

@yk yk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you remove the ansible part? so we can get this merged. can you also make a new issue for including redis in ansible? I'll take that myself and do it later.

@GraemeHarris GraemeHarris force-pushed the add-redis-for-rate-limit branch from d5a7864 to 3bb0b04 Compare January 1, 2023 11:35
@andreaskoepf
Copy link
Collaborator

@yk is this ready for merge?

@kiritowu
Copy link
Collaborator

kiritowu commented Jan 1, 2023

@GraemeHarris do you intend to add redis (and redis-insights) to Line 7 in the docker-compose.yml such that both redis and redis-insights will be started up for backend-dev purpose?

  backend-dev:
    image: sverrirab/sleep
    depends_on: [db, adminer, redis, redis-insights]

Copy link
Collaborator

@yk yk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@yk yk merged commit ce1317d into LAION-AI:main Jan 1, 2023
@GraemeHarris GraemeHarris deleted the add-redis-for-rate-limit branch January 2, 2023 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants