-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add basic redis setup for rate limiting #187
Conversation
also, some merge conflicts |
bdc2129
to
1ec5c43
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you remove the ansible part? so we can get this merged. can you also make a new issue for including redis in ansible? I'll take that myself and do it later.
d5a7864
to
3bb0b04
Compare
@yk is this ready for merge? |
@GraemeHarris do you intend to add backend-dev:
image: sverrirab/sleep
depends_on: [db, adminer, redis, redis-insights] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
As per #175 redis setup to be used for rate limiting - maybe BE cache down the line.
I have updated the docker compose file to include redis + redis insights. They're quite basic for now with a lot of settings that can be tweaked as per need / feedback.
Ansible changes might need more testing