#42 Adding popover to flag text with labels #189
Conversation
BitterKanegul
requested review from
fozziethebeat,
k-nearest-neighbor and
AbdBarho
as code owners
|
|
||
| export type TextFlagProps = { | ||
| text: string; | ||
| label_map; |
There was a problem hiding this comment.
label_map: Record<string, string>?
| import { QuestionMarkCircleIcon, FlagIcon } from "@heroicons/react/20/solid"; | ||
| import { useState } from "react"; | ||
|
|
||
| export type TextFlagProps = { |
There was a problem hiding this comment.
This is not referenced anywhere?
There was a problem hiding this comment.
I have removed it now!
| let label_map: Map<string, number> = new Map(); | ||
| label_refs | ||
| .filter((flagRef) => flagRef.isChecked) | ||
| .map((refs) => { |
There was a problem hiding this comment.
maybe you want forEach? or replacee the entire thing with reduce?
| labelText: string; | ||
| additionalExplanation?: string; | ||
| } | ||
| const TEXT_LABEL_FLAGS: textFlagLabels[] = [ |
There was a problem hiding this comment.
this is the same as in rate_summary.tsx right? should we extract it to some shared variable?
There was a problem hiding this comment.
I think the simpler thing to do is in a follow up PR delete the code in rate_summary.tsx when this component is added to it.
|
Assuming that a follow on PR will use this component in each of the tasks, this looks good once pre-commits are green. |
|
@BitterKanegul run |
BitterKanegul
force-pushed
the
42-implement-text-labels-web-frontend
branch
from
567fc25 to
e81c3cd
Compare
| const [checkboxValues, setCheckboxValues] = useState(new Array(TEXT_LABEL_FLAGS.length).fill(false)); | ||
| const [sliderValues, setSliderValues] = useState(new Array(TEXT_LABEL_FLAGS.length).fill(1)); | ||
|
|
||
| const fetchData = () => { |
There was a problem hiding this comment.
small detail, does this need to be a separate function? It seems to only be called when calling submitResponse. We could simplify this by putting it all in submitResponse
There was a problem hiding this comment.
thank you! I've added the same and ran precommit and npm run build. No issues now!
No description provided.