-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Format markdown with prettier --prose-wrap=always #212
Conversation
is this common for markdown files? to me, it seems quite annoying to have sentences split up over multiple lines, because if I want to change one, I need to jump between lines. I usually just rely on my terminal or editor to do proper wrapping. If this is standard, I'm happy to adopt it, but it seems a bit strange. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved for web and copilot changes.
I'm a fan of line length limits.
Yeah it's standard as per markdownlint at least, and is the norm outside of the ML space. Prettify should do the formatting automatically on the pre-commit hook so you don't have to worry about it too much. I find it nicer to work with, there's something beautiful about having an ASCII art doc as the source code for rich text. It's also kinda oldskool and feels like a hacker zine, nfo file or license.txt, but that could be a personal bias. The original authors used that format in their examples though: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SGTM, Thank you for everyone's inputs :)
Could you resolve the merge conflicts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs to be run on recently added READMEs as well..
09bc85e
to
c3c7a17
Compare
I re-ran it. It might conflict with #239 though, if that goes in first then lemme know and I'll rebase + run again. Might as well document the rebase process in case it's useful to anyone else in future:
|
could you add this to the main README ? |
Not sure it's that useful outside of this specific issue - all my It could be pretty useful added to |
As per discussion on LAION-AI#212
Not being able to read the docs in the console was bugging me, so I've added
--prose-wrap=always
to the precommit config.Makes the readme's readable in less, easier to grep, and (IMO) look much nicer in a terminal. Also stops markdownlint from barfing so much in vscode.