tests: add OasstApiClient contract tests #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the previous iteration of this script which used wiremock threw a null pointer exception.
This is required for output validation and for the mock server.
jack-michaud
changed the title
andreaskoepf
reviewed
Jan 1, 2023
| @@ -204,7 +204,7 @@ def tasks_acknowledge_failure( | |||
| raise OasstError("Failed to not acknowledge task.", OasstErrorCode.TASK_NACK_FAILED) | |||
|
|
|||
|
|
|||
| @router.post("/interaction") | |||
| @router.post("/interaction", response_model=protocol_schema.TaskDone) | |||
There was a problem hiding this comment.
@yk note on how to specify multiple possible response_models: https://stackoverflow.com/questions/72919006/is-there-any-way-to-have-multiple-response-models-in-fastapi-openapi
andreaskoepf
approved these changes
Jan 1, 2023
jack-michaud
commented
Jan 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #205
Not in this PR but will complete in my next PR: adding a github workflow which automatically runs the tests for each PR and push.