Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

candidate platform agnostic solution #227

Merged
merged 1 commit into from
Jan 1, 2023
Merged

candidate platform agnostic solution #227

merged 1 commit into from
Jan 1, 2023

Conversation

mattlongname
Copy link
Contributor

Candidate solution for: #195
Tested on these platforms:

  • Windows 21H2
  • Ubuntu 22.04
  • macOS 12.6.1
  • github Actions:pre-commit (forked branch pull request)

Each platform had native node/npm and python/pip installed. I ran the following commands from the project root directory:

pip install pre-commit
pre-commit install
pre-commit run --all-files

Containerized development environments would make this a non-issue. Regardless, here is a low impact, candidate solution that could better serve native environments, containerized environments, and github workflows.

Copy link
Collaborator

@yk yk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks very nice, thank you! I'll try it out a bit and then merge

@yk yk linked an issue Jan 1, 2023 that may be closed by this pull request
@yk yk closed this Jan 1, 2023
@yk yk reopened this Jan 1, 2023
@yk yk merged commit 5a90283 into LAION-AI:main Jan 1, 2023
@yk
Copy link
Collaborator

yk commented Jan 1, 2023

sorry for closing, clicked wrong button 🙃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to run pre-commit on a windows 10 machine
2 participants