Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added clear list for more understanding of result #278

Merged
merged 1 commit into from
Jan 3, 2023
Merged

added clear list for more understanding of result #278

merged 1 commit into from
Jan 3, 2023

Conversation

chandru1003
Copy link
Contributor

@chandru1003 chandru1003 commented Jan 2, 2023

changes are done by me

  • added one comment
  • added clear() to list instructions
    - which does not your output but every time I ran value gets appended to the list so it makes it confusing to understand so clear list after printing the list, now only output/value gets appended to the list which line ran.
  • import random in fist cell because it throwing error for me

@yk
Copy link
Collaborator

yk commented Jan 2, 2023

@Graverman-dev could you give your input here?

@GravermanDev
Copy link

well I looked at the file and I cannot find any changes besides one comment, unless I missed something @chandru1003. You can merge because the comment is okay but I don't see any differences like at all

@yk
Copy link
Collaborator

yk commented Jan 2, 2023

@chandru1003 could you explain a bit what you've changed?

@chandru1003
Copy link
Contributor Author

@Graverman-dev could you give your input here?
when you ran any other cell it is added to the list and makes clutter
Fix structure errors in this essay
Fix grammar errors in this essay
Fix typing errors in this essay
Fix typing errors in this essay
Fix grammar errors in this essay

if we clear the list, the output will
run 1
Fix structure errors in this essay
Fix grammar errors in this essay
Fix typing errors in this essay
run 2
Fix typing errors in this essay

@chandru1003
Copy link
Contributor Author

changes are done by me

  • added one comment
  • added clear() to list instructions
    • which does not your output but every time I ran value gets appended to the list so it makes it confusing to understand so clear list after printing the list, now only output/value gets appended to the list which line ran.
  • import random in fist cell because it throwing error for me

well I looked at the file and I cannot find any changes besides one comment, unless I missed something @chandru1003. You can merge because the comment is okay but I don't see any differences like at all

changes are done by me

added one comment
added clear() to list instructions

  • which does not your output but every time I ran value gets appended to the list so it makes it confusing to understand so clear list after printing the list, now only output/value gets appended to the list which line ran.
    import random in fist cell because it throwing error for me

@yk yk merged commit d7583ef into LAION-AI:main Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants