Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added data schemas md #288

Merged
merged 1 commit into from
Jan 2, 2023
Merged

added data schemas md #288

merged 1 commit into from
Jan 2, 2023

Conversation

yk
Copy link
Collaborator

@yk yk commented Jan 2, 2023

No description provided.

@yk yk requested a review from andreaskoepf as a code owner January 2, 2023 20:06
@yk yk requested a review from rom1504 January 2, 2023 20:07
@yk yk mentioned this pull request Jan 2, 2023
Closed
andreaskoepf
andreaskoepf approved these changes Jan 2, 2023
View reviewed changes
Copy link
Collaborator

@andreaskoepf andreaskoepf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for schemas. Igor created similar structures for the backend API .. maybe you could refactor that to also become ConversationTreeNode & ConsersationTree .. e.g. adding user and date inso as metadata and not direct members.

@andreaskoepf andreaskoepf merged commit 0a59aeb into main Jan 2, 2023
@andreaskoepf andreaskoepf deleted the data-schemas branch January 2, 2023 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreaskoepf andreaskoepf andreaskoepf approved these changes

@rom1504 rom1504 Awaiting requested review from rom1504

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yk @andreaskoepf