Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added collapsable text for text that's too long #303

Merged
merged 5 commits into from
Jan 4, 2023

Conversation

kostiak
Copy link
Contributor

@kostiak kostiak commented Jan 3, 2023

This is a draft PR for #190

@kostiak kostiak marked this pull request as ready for review January 3, 2023 01:49
Copy link
Collaborator

@fozziethebeat fozziethebeat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks solid. Will approve after merging in the changes from dark mode!

@kostiak
Copy link
Contributor Author

kostiak commented Jan 3, 2023

@fozziethebeat As I said in #190, I still have an issue here in that a modal does not take up the full width/height of the screen:
image

I can probably fix it using style tags, but I think there might be a simpler way to fix it that I'm missing. Can you take a look at it on mobile/using the browser mobile emulator?

Thanks.

@fozziethebeat
Copy link
Collaborator

@fozziethebeat As I said in #190, I still have an issue here in that a modal does not take up the full width/height of the screen: image

I can probably fix it using style tags, but I think there might be a simpler way to fix it that I'm missing. Can you take a look at it on mobile/using the browser mobile emulator?

Thanks.

I tried it out locally and deleted the Container in website/src/components/CollapsableText.tsx. That fixed the width issue for me. Can you try that?

@kostiak
Copy link
Contributor Author

kostiak commented Jan 3, 2023

@fozziethebeat
I tried that. Doesn't seem to fix it for me.

It works correcly on "small" screens, but when I try it in the device emulator:
image

@kostiak
Copy link
Contributor Author

kostiak commented Jan 3, 2023

@fozziethebeat
Hey, fixed the overlay with a style tag for now, this is how it looks on mobile:
image

Let me know what you think.

@kostiak kostiak requested a review from fozziethebeat January 3, 2023 21:35
Copy link
Collaborator

@fozziethebeat fozziethebeat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is good enough for a first start. It's functional on mobile although not ideal. We can iterate later after other things.

@fozziethebeat fozziethebeat merged commit 65d2706 into LAION-AI:main Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants