-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added collapsable text for text that's too long #303
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks solid. Will approve after merging in the changes from dark mode!
@fozziethebeat As I said in #190, I still have an issue here in that a modal does not take up the full width/height of the screen: I can probably fix it using style tags, but I think there might be a simpler way to fix it that I'm missing. Can you take a look at it on mobile/using the browser mobile emulator? Thanks. |
I tried it out locally and deleted the |
@fozziethebeat It works correcly on "small" screens, but when I try it in the device emulator: |
@fozziethebeat Let me know what you think. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is good enough for a first start. It's functional on mobile although not ideal. We can iterate later after other things.
This is a draft PR for #190