Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make menu icon visible in dark mode #328

Merged
merged 1 commit into from
Jan 4, 2023
Merged

Make menu icon visible in dark mode #328

merged 1 commit into from
Jan 4, 2023

Conversation

chs20
Copy link
Contributor

@chs20 chs20 commented Jan 3, 2023

Set the stroke of the menu icon based on the current color mode.

Before:
before

After:
after

AbdBarho
AbdBarho reviewed Jan 3, 2023
View reviewed changes
Copy link
Collaborator

@AbdBarho AbdBarho left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @chs20 for contributing!

We have a big PR containing many changes to different component including dark mode changes.
I am not sure if this is also addressed there: #312

This is a small change so I think we can merge regardless, what do others think?

@AbdBarho AbdBarho added website UI/UX All website Components labels Jan 3, 2023
fozziethebeat
fozziethebeat approved these changes Jan 4, 2023
View reviewed changes
Copy link
Collaborator

@fozziethebeat fozziethebeat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve. The dashboard change may take a while to get ready so we can add this in.

@fozziethebeat fozziethebeat merged commit e571568 into LAION-AI:main Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbdBarho AbdBarho AbdBarho left review comments

@fozziethebeat fozziethebeat fozziethebeat approved these changes

@k-nearest-neighbor k-nearest-neighbor Awaiting requested review from k-nearest-neighbor

Assignees
No one assigned
Labels
UI/UX All website Components website
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chs20 @fozziethebeat @AbdBarho