about page #335
about page #335
Conversation
brentbagapuro
requested review from
fozziethebeat,
k-nearest-neighbor and
AbdBarho
as code owners
| <Container className=""> | ||
| <div className="py-32"> | ||
| <h2 className="text-4xl mb-16">Our Roadmap</h2> | ||
| <div className="flex flex-col items-center space-y-8 md:space-y-0 md:items-start md:flex-row md:justify-between"> |
There was a problem hiding this comment.
@brentbagapuro thanks for the contribution!
I don't think it is necessary for this page since it only shows info with little interaction. But at some point we have to migrate to using chakra-ui.
For any future pull requests, prefer chakra-ui instead of raw html if possible ❤.
I cannot judge the content so I will wait for other reviewers from the team. But it looks good to me.
There was a problem hiding this comment.
Thank you for you review @AbdBarho ! Appreciate it.
I understand. Was only basing on current layout of the homepage as it's mostly Tailwind styling as I did here. I also consulted with @fozziethebeat about my approach to use Tailwind UI when asking to assign the issue to me.
Nevertheless, I'll make sure future PRs prioritize chakra-ui for building the UI.
Thank you again! ❤
There was a problem hiding this comment.
I answered in the issue a bit too quickly. @AbdBarho is correct, Chakra-UI components are preferred over raw tailwind whenever possible but as a first draft it's not a big deal. We can switch things out later
There was a problem hiding this comment.
Gotcha. I'll take note of that. Thanks!
| <Container className=""> | ||
| <div className="py-32"> | ||
| <h2 className="text-4xl mb-16">Our Roadmap</h2> | ||
| <div className="flex flex-col items-center space-y-8 md:space-y-0 md:items-start md:flex-row md:justify-between"> |
There was a problem hiding this comment.
I answered in the issue a bit too quickly. @AbdBarho is correct, Chakra-UI components are preferred over raw tailwind whenever possible but as a first draft it's not a big deal. We can switch things out later
This change resolves issue #229: Design an informative /about on the website