Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor + test: add OasstApiClient in website with tests #342

Merged
merged 7 commits into from
Jan 5, 2023
Merged

refactor + test: add OasstApiClient in website with tests #342

merged 7 commits into from
Jan 5, 2023

Conversation

jack-michaud
Copy link
Collaborator

@jack-michaud jack-michaud commented Jan 3, 2023 •
edited
Loading

Fixes #204

@jack-michaud jack-michaud marked this pull request as ready for review January 4, 2023 02:04
This was referenced Jan 4, 2023
Closed
Closed
fozziethebeat
fozziethebeat approved these changes Jan 4, 2023
View reviewed changes
Copy link
Collaborator

@fozziethebeat fozziethebeat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. I'm approving given that you'll need others to review before it's ready to merge. Please update the comment to reference the issue and ensure the issue isn't closed yet.

AbdBarho
AbdBarho approved these changes Jan 4, 2023
View reviewed changes
Copy link
Collaborator

@AbdBarho AbdBarho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! waiting on non-web devs approval.

@jack-michaud jack-michaud enabled auto-merge January 4, 2023 20:01
@jack-michaud jack-michaud disabled auto-merge January 4, 2023 20:02
yk
yk approved these changes Jan 5, 2023
View reviewed changes
Copy link
Collaborator

@yk yk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you very much, amazing!

@fozziethebeat fozziethebeat merged commit 38fec23 into LAION-AI:main Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fozziethebeat fozziethebeat fozziethebeat approved these changes

@yk yk yk approved these changes

@AbdBarho AbdBarho AbdBarho approved these changes

@k-nearest-neighbor k-nearest-neighbor Awaiting requested review from k-nearest-neighbor

@andreaskoepf andreaskoepf Awaiting requested review from andreaskoepf andreaskoepf is a code owner

Assignees
No one assigned
Labels
website
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Contract tests between API and website
4 participants
@jack-michaud @fozziethebeat @yk @AbdBarho