Add warning when submitting unchanged ranking #345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephancill
requested review from
fozziethebeat,
k-nearest-neighbor and
AbdBarho
as code owners
stephancill
changed the title
fozziethebeat
requested changes
Jan 4, 2023
|
(I removed the backend label since the proposed change is in the website code.) |
fozziethebeat
approved these changes
Jan 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #272.
When the list is unchanged and the user tries to submit, they are presented with this modal:
Something that may be an issue is that once the modal is presented, if the user presses Cancel, and they click submit again, it won't be presented again. More information on L27 of website/src/components/Survey/TaskControlsOverridable.tsx. Not sure how important this is but will required additional refactoring to fix.