Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs site poc #346

Merged
merged 53 commits into from
Jan 6, 2023
Merged

Docs site poc #346

merged 53 commits into from
Jan 6, 2023

Conversation

andrewm4894
Copy link
Collaborator

@andrewm4894 andrewm4894 commented Jan 3, 2023

related to this issue: #340

you can see the docs site create by this branch here: https://andrewm4894.github.io/Open-Assistant/

changes:

  • add docusaurus project under /docs
  • add gh action to deploy changes under /docs
  • run yarn install within devcontainer so users can just do cd docs; yarn start to work on docs and see impacts if they want.

to try this out

create codespace on https://github.com/andrewm4894/Open-Assistant/tree/docs-site-poc

cd docs
yarn install
yarn start

Then the docs site will by default be served on port 3000 so you can look in there and changes should be reflected automatically.

So as you work on docs then you can see impact straight away.

image

@andrewm4894
Copy link
Collaborator Author

if we merge this then someone with access would just need to go to the github pages part of the repo settings and do this:

image

We would also need to make one last commit (or small follow on PR) - to update all the andrewm4894 parts of the docusaurus config with LAION-AI. (just have to use andrewm4894 for now to make sure my example site builds from my fork).

@andrewm4894 andrewm4894 mentioned this pull request Jan 4, 2023
Copy link
Collaborator

@bitplane bitplane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really have the skill level to review js/ts files so just stuck my dirty oar in about .gitignore while reading about docusaurus. It looks really cool. Nice work :)

@andrewm4894
Copy link
Collaborator Author

@yk @andreaskoepf what you think about this - i'm happy to take on any donkey work around maintaining it, helping users add to it and things like that. Just thinking a decent docs site might help onboard people easier over next while and maybe help them to not have to dig through .md files on GH (which they could still do too if they wanted since this really just about packaging up existing .md files to given them a bit of an obvious structure).

Copy link
Collaborator

@yk yk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool, thank you!

Comment on lines +5 to +7
cd docs
yarn install
cd ..
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we can leave this away? how much time does it add?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Takes a few seconds, maybe worth having in default container to make it super easy for people to build docs site in a codespace if they want. Of course all they read need do is change a .md file and the workflow will build or fail so if not like they need to.

But maybe handy to have there to make docs contributions as frictionless as possible.

const config = {
title: "Open Assistant",
tagline: "Build the assistant of the future!",
url: "https://andrewm4894.github.io",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this probably needs to become the main url :)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, I can change all that in one last commit now before we merge this. Was just leaving like that so my site was working.

Will make follow up commit to this branch to replace all the andrewm4894 with LAION-AI

@andrewm4894
Copy link
Collaborator Author

I will resolve conflicts and finalize the urls in one last commit. Will ping again once done.

@andrewm4894 andrewm4894 merged commit d24c127 into LAION-AI:main Jan 6, 2023
@andrewm4894 andrewm4894 deleted the docs-site-poc branch January 6, 2023 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants