Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix #173 - Empty task interactions #373

Merged
merged 3 commits into from
Jan 5, 2023
Merged

Bugfix #173 - Empty task interactions #373

merged 3 commits into from
Jan 5, 2023

Conversation

GraemeHarris
Copy link
Collaborator

Added some pydantic validation updated to the protcol types to prevent empty text, lists and ratings less than zero for user replies: #273

andreaskoepf
andreaskoepf approved these changes Jan 5, 2023
View reviewed changes
Copy link
Collaborator

@andreaskoepf andreaskoepf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, we are getting pydantic.. ;-) ...

@andreaskoepf andreaskoepf merged commit c2b6cdb into main Jan 5, 2023
@andreaskoepf andreaskoepf deleted the bugfix-empty-task-interactions branch January 5, 2023 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreaskoepf andreaskoepf andreaskoepf approved these changes

@yk yk Awaiting requested review from yk yk is a code owner

Assignees
No one assigned
Labels
backend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GraemeHarris @andreaskoepf @fozziethebeat