Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

344: Create tasks for text labels #381

Merged
merged 14 commits into from
Jan 6, 2023
Merged

344: Create tasks for text labels #381

merged 14 commits into from
Jan 6, 2023

Conversation

olliestanley
Copy link
Collaborator

@olliestanley olliestanley commented Jan 4, 2023 •
edited
Loading

This adds backend support for text label tasks for initial prompts and replies. Also adds support for the tasks to the discord-bot and the text-frontend, but not the website

@olliestanley olliestanley mentioned this pull request Jan 4, 2023
Closed
@olliestanley olliestanley marked this pull request as ready for review January 4, 2023 20:53
yk
yk reviewed Jan 5, 2023
View reviewed changes
Copy link
Collaborator

@yk yk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much, really nice work. I've left some comments

@andreaskoepf
Copy link
Collaborator

@olliestanley would it be possible for you to join our OA discord server and ping me? https://discord.gg/HFCPfugy

yk
yk approved these changes Jan 5, 2023
View reviewed changes
Copy link
Collaborator

@yk yk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now, thank you very much! maybe let's wait for andreas' final comments

@yk
Copy link
Collaborator

yk commented Jan 5, 2023

also, once we merge, please post this into the breaking-changes channel and tag the web-team

@olliestanley
Copy link
Collaborator Author

Message ID is now sent out with the task as requested by @andreaskoepf and I have tested using the text-frontend to successfully complete label tasks. Will wait for any final comments from Andreas before merge and can then notify the web team of the breaking change in the text_labels endpoint

andreaskoepf
andreaskoepf requested changes Jan 6, 2023
View reviewed changes
Copy link
Collaborator

@andreaskoepf andreaskoepf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall looks good .. added some minor comments.

andreaskoepf
andreaskoepf approved these changes Jan 6, 2023
View reviewed changes
Copy link
Collaborator

@andreaskoepf andreaskoepf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, lets merge this! :-)

@andreaskoepf andreaskoepf merged commit 69bc799 into LAION-AI:main Jan 6, 2023
@olliestanley olliestanley mentioned this pull request Jan 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yk yk yk approved these changes

@andreaskoepf andreaskoepf andreaskoepf approved these changes

Assignees
No one assigned
Labels
backend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@olliestanley @andreaskoepf @yk @fozziethebeat