Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DEBUG_USD_SEED_DATA_PATH in config to make seed data flexible #395

Merged
merged 4 commits into from
Jan 7, 2023

Conversation

kenhktsui
Copy link
Collaborator

@kenhktsui kenhktsui commented Jan 5, 2023

Closes #322

Factor out fixed seed data by adding DEBUG_USE_SEED_DATA_PATH in config to control seed data to use

@kenhktsui kenhktsui marked this pull request as ready for review January 6, 2023 09:40
@kenhktsui kenhktsui changed the title Draft: Add DEBUG_USD_SEED_DATA_PATH in config to make seed data flexible Add DEBUG_USD_SEED_DATA_PATH in config to make seed data flexible Jan 6, 2023
@kenhktsui kenhktsui force-pushed the 322-flexible-seed-data branch from f29331a to 1854a9f Compare January 6, 2023 16:01
Copy link
Collaborator

@andreaskoepf andreaskoepf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks.

@andreaskoepf andreaskoepf self-requested a review January 6, 2023 18:28
Copy link
Collaborator

@andreaskoepf andreaskoepf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The automatic contract-tests fail with during start of the mock-server with the following error-message:

 pydantic.error_wrappers.ValidationError: 1 validation error for Settings
DEBUG_USE_SEED_DATA_PATH
  file or directory at path "backend/test_data/generic/test_generic_data.json" does not exist (type=value_error.path.not_exists; path=backend/test_data/generic/test_generic_data.json)

Could you please check & fix?

- correct test_data path in  Dockerfile.backend
@kenhktsui
Copy link
Collaborator Author

The automatic contract-tests fail with during start of the mock-server with the following error-message:

 pydantic.error_wrappers.ValidationError: 1 validation error for Settings
DEBUG_USE_SEED_DATA_PATH
  file or directory at path "backend/test_data/generic/test_generic_data.json" does not exist (type=value_error.path.not_exists; path=backend/test_data/generic/test_generic_data.json)

Could you please check & fix?

Thanks for checking! The path of test_data now became absolute (dynamically) thanks to yk's suggestion. I could run start-mock-server.sh without error now.

@andreaskoepf andreaskoepf enabled auto-merge (squash) January 7, 2023 12:40
@andreaskoepf andreaskoepf merged commit 043b5ef into LAION-AI:main Jan 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make backend seed data more realistic
4 participants