Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace npm install with npm ci #424

Merged
merged 1 commit into from
Jan 6, 2023
Merged

Replace npm install with npm ci #424

merged 1 commit into from
Jan 6, 2023

Conversation

Vechtomov
Copy link
Collaborator

npm ci is intended for a deterministic, repeatable build and npm install for adding new dependencies and updating existing.
npm ci is already used in the project in Dockerfile.website and build-frontend.yaml.
Here are the full list of differences with npm install: https://stackoverflow.com/questions/52499617/what-is-the-difference-between-npm-install-and-npm-ci

@fozziethebeat
Copy link
Collaborator

Thank you! yes npm ci is better in these situations.

Copy link
Collaborator

@yk yk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@yk yk merged commit 80e1014 into LAION-AI:main Jan 6, 2023
@Vechtomov Vechtomov deleted the npm-ci branch January 6, 2023 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants