Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#309 - Message navigation #440

Merged
merged 11 commits into from
Jan 7, 2023
Merged

#309 - Message navigation #440

merged 11 commits into from
Jan 7, 2023

Conversation

jojopirker
Copy link
Contributor

This was referenced Jan 6, 2023
Closed
Closed
fozziethebeat
fozziethebeat reviewed Jan 6, 2023
View reviewed changes
Copy link
Collaborator

@fozziethebeat fozziethebeat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Broadly this looks right! Tidy up as much as you think needed and I'll do a more careful review.

@jojopirker
Copy link
Contributor Author

made a few changes to make it recursive...
Looks the same if message tree is not big, but still has some visual quirks with a bigger trees (see attached video)

@fozziethebeat maybe you got some ideas how to properly style it...
I would leave it as a draft still but I think you could already take a look at the code, please :)

Screen.Recording.2023-01-06.at.15.42.40.mov

@fozziethebeat
Copy link
Collaborator

I don't see many code suggestions to make. It's clean and pretty easy to understand. Later I think we can fold the backend fetch calls into a library someone is working on but I'm also trying to negotiate not having these API routes anyways so it's not a huge issue.

Will approve once you feel it's ready

@jojopirker
Copy link
Contributor Author

should be ready now :)

Screenshot 2023-01-07 at 10 23 59

@jojopirker jojopirker marked this pull request as ready for review January 7, 2023 09:24
@fozziethebeat fozziethebeat merged commit d59a75a into LAION-AI:main Jan 7, 2023
@AbdBarho
Copy link
Collaborator

AbdBarho commented Jan 7, 2023 •
edited
Loading

This actually looks cool!!!

@jojopirker jojopirker deleted the messageNavigation branch January 7, 2023 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fozziethebeat fozziethebeat fozziethebeat approved these changes

@k-nearest-neighbor k-nearest-neighbor Awaiting requested review from k-nearest-neighbor

@AbdBarho AbdBarho Awaiting requested review from AbdBarho AbdBarho is a code owner

Assignees
No one assigned
Labels
website
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jojopirker @fozziethebeat @AbdBarho