Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for multiple devcontainers #445

Merged
merged 4 commits into from
Jan 6, 2023

Conversation

andrewm4894
Copy link
Collaborator

@andrewm4894 andrewm4894 commented Jan 6, 2023

changes:

  • add .devcontainer/frontend/ that just pre-runs npm install from within the /website/ dir.
  • add note to .devcontainer/README.md about this.

this looks like a useful way to add multiple different types of devcontainers that might be useful over time and is much cleaner than what i was suggesting in #422

@andrewm4894 andrewm4894 changed the title add support for devcontainers add support for multiple devcontainers Jan 6, 2023
@andrewm4894 andrewm4894 marked this pull request as ready for review January 6, 2023 14:02
@andrewm4894 andrewm4894 enabled auto-merge January 6, 2023 14:02
Copy link
Collaborator

@yk yk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, very cool!

@andrewm4894 andrewm4894 merged commit 1d927b1 into LAION-AI:main Jan 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants