#435 Added longer response incentive #457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Klotske
requested review from
fozziethebeat,
k-nearest-neighbor and
AbdBarho
as code owners
|
Main issue with state addition is the constant re-rendering of the whole page. Not sure how to prevent such behaviour. |
fozziethebeat
approved these changes
Jan 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#435
As per #435 (comment) added new
TrackedTextareacomponent, which implements basic word count progress bar.The word tracker has three threshold points as required props.
The ref forwarding was getting complicated (was not sure how to properly update the word counter when setting value with
inputRef.current.valueas it does not trigger re-rendering) so I decided to addinputTextstate to each page.Also, we should deside on thresholds for the response's word count.
PS
All e2e tests ran perfectly.