Adding a very rudimentary admin page that displays a table of users #476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd their basic information
fozziethebeat
requested review from
k-nearest-neighbor and
AbdBarho
as code owners
AbdBarho
reviewed
Jan 7, 2023
website/src/components/UsersCell.tsx
Outdated
Comment on lines
13
to
14
| onSuccess: (data) => { | ||
| setUsers(data); |
website/src/pages/admin/index.tsx
Outdated
| }, [session, status]); | ||
|
|
||
| // While loading, just show something. | ||
| if (status === "loading") { |
There was a problem hiding this comment.
could you please extract shared stuff out of the if statement?
the only thing different is contents of main:
<main className="oa-basic-theme">
{status === "loading": "loading..." : <UserCell/>}
</main>There was a problem hiding this comment.
Done. This came from a bit of moving things around and I didn't realize it could be cleaner.
AbdBarho
approved these changes
Jan 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This starts #237 with a very basic and minimally styled version. This does not include any management functionality, that will be in a follow up PR.