Label Initial Prompt #477
Merged
Label Initial Prompt #477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I like the direction this is going. I agree that the fetching is getting way out of hand. |
AbdBarho
force-pushed
the
label-initial-prompt
branch
4 times, most recently
from
2ef3192 to
bf2ee70
Compare
AbdBarho
force-pushed
the
label-initial-prompt
branch
2 times, most recently
from
f48a715 to
7030882
Compare
AbdBarho
force-pushed
the
label-initial-prompt
branch
from
7030882 to
2a5d37a
Compare
AbdBarho
requested review from
fozziethebeat and
k-nearest-neighbor
as code owners
AbdBarho
commented
Jan 7, 2023
| }); | ||
|
|
||
| const submit = (id: string, message_id: string, text: string, labels: Record<string, string>) => | ||
| trigger({ id, update_type: "text_labels", content: { labels, text, message_id } }); |
There was a problem hiding this comment.
@fozziethebeat I had to override the message_id here otherwise the (real) backend would error.
interaction.id from prisma did not work.
There was a problem hiding this comment.
Yes that looks correct. interaction.id is just a web thing that can be ignored during backend interactions.
This was referenced Jan 7, 2023
fozziethebeat
approved these changes
Jan 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #436
I started to consolidate the shared code with regards to fetching and mutating to its own hook.
The amount of code duplication is starting to get out of hand...
I still need to add the actual flagging, for that I want to refactor
FlaggableElement, but maybe in another PR because this will become too big.Also, now we show the raw labels delivered from the backend, we need to define corresponding texts to display.