#438 Frontend type #483
Merged
#438 Frontend type #483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jojopirker I think you forgot to add the file |
andreaskoepf
reviewed
Jan 7, 2023
backend/README.md
Outdated
|
|
||
| ## Alembic | ||
|
|
||
| To the database run `alembic revision -m "..."` ("..." is what you did) in the `/backend` directory. Then edit the newly created file. See [here](https://alembic.sqlalchemy.org/en/latest/tutorial.html) for more information. |
There was a problem hiding this comment.
This should be alembic revision --autogenerate -m "..." ... and I think at the beginning of the sentence it should be "To create an Alembic database migration script after sql-models were modified run alembic revision --autogenerate -m "...""
|
Regarding |
|
I always forget pre-commit 🤦 |
Thanks for the fixes. Consider running |
andreaskoepf
approved these changes
Jan 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added FrontendType to database and class, also changed the readme a bit to have everything at one place