Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bot update #5

Merged
merged 4 commits into from
Dec 14, 2022
Merged

Bot update #5

merged 4 commits into from
Dec 14, 2022

Conversation

BirgerMoell
Copy link
Collaborator

Added buttons and review prompts command to the bot.

@BirgerMoell BirgerMoell requested a review from yk as a code owner December 13, 2022 22:53
yk
yk approved these changes Dec 13, 2022
View reviewed changes
Copy link
Collaborator

@yk yk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not for now, but maybe to think about:

  • type hints
  • error handling
  • logging instead of print (can recommend loguru)

@yk yk merged commit 6048f54 into main Dec 14, 2022
@yk yk deleted the bot-update branch December 14, 2022 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yk yk yk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BirgerMoell @yk