Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conversation messages refactor add msg ids #500

Merged
merged 6 commits into from
Jan 7, 2023
Merged

Conversation messages refactor add msg ids #500

merged 6 commits into from
Jan 7, 2023

Conversation

danielpatrickhug
Copy link
Collaborator

  • in oasst_shared/schemas/protocal.py I modified ConversationMessage adding the variable message_id and frontend_message_id
  • in backend/oasst_backend/api/v1 I modified instances of ConversationMessage in tasks.py and utils.py to include the new variable when instantiating ConversationMessage
  • in backend main.py I updated the instantiation of conversation message to include message_id and frontend_id
  • Ran pre-commit to format

andreaskoepf
andreaskoepf approved these changes Jan 7, 2023
View reviewed changes
Copy link
Collaborator

@andreaskoepf andreaskoepf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, nice .. looks good! :-)

@andreaskoepf andreaskoepf merged commit f75a073 into LAION-AI:main Jan 7, 2023
@notmd notmd mentioned this pull request Jan 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreaskoepf andreaskoepf andreaskoepf approved these changes

@yk yk Awaiting requested review from yk yk is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danielpatrickhug @andreaskoepf