#371 set labels #518
Merged
#371 set labels #518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: minimum changes to textFlagLabels to keep it coherent with the backend
fix: minimum changes to textFlagLabels to keep it coherent with the backend
melvinebenezer
requested review from
fozziethebeat,
k-nearest-neighbor and
AbdBarho
as code owners
fozziethebeat
requested changes
Jan 8, 2023
….tsx due to previous message_id changes
fozziethebeat
approved these changes
Jan 8, 2023
|
It looks like all of @AbdBarho's changes were resolved. Merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIXED
Making a new web api route under website/src/pages/api/set_label.tsx
Update the component website/src/components/FlaggableElement.tsx to call this web API route
Implement the web API route to forward the tag content to the backend server using the API key
Temporary fix for test_labels map until Use API to populate text_labels in frontend #493 and add api/v1/text_labels/valid_labels backend endpoint #498 will be fixed
Test Evidence
Front End
Database updates
