Adding an admin page to manage a specific user's status #521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fozziethebeat
requested review from
k-nearest-neighbor and
AbdBarho
as code owners
AbdBarho
requested changes
Jan 8, 2023
| return ( | ||
| <> | ||
| <Head> | ||
| <title>Open Assistant</title> |
There was a problem hiding this comment.
Manage Users - Open Assistant
| initialValues={user} | ||
| onSubmit={(values) => { | ||
| trigger(values); | ||
| }} |
There was a problem hiding this comment.
npm run build really didn't like that due to some type issues. Will leave as is for now.
Comment on lines
8
to
14
| const token = await getToken({ req }); | ||
|
|
||
| // Return nothing if the user isn't registered or if the user isn't an admin. | ||
| if (!token || token.role !== "admin") { | ||
| res.status(403).end(); | ||
| return; | ||
| } |
There was a problem hiding this comment.
could we extract these to a middleware?
maybe something like:
const handler = withAdmin(async (token, req, res) => {
...
});or maybe
const handler = withRole("admin", async (token, req, res) => {
...
});There was a problem hiding this comment.
Done. I looked at using the actual middleware.ts but it looks a bit too messy. A wrapper is a lot cleaner. makes me miss RedwoodJS where they built this into the graphQL handler.
AbdBarho
approved these changes
Jan 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes:
Not done yet: