Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

536: Add endpoint to resolve frontend user by auth method and username #539

Merged
merged 9 commits into from
Jan 10, 2023
Merged

536: Add endpoint to resolve frontend user by auth method and username #539

merged 9 commits into from
Jan 10, 2023

Conversation

olliestanley
Copy link
Collaborator

Resolves #536

@Vechtomov Vechtomov mentioned this pull request Jan 8, 2023
Closed
andreaskoepf
andreaskoepf reviewed Jan 9, 2023
View reviewed changes
Copy link
Collaborator

@andreaskoepf andreaskoepf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • fallback to api_client.id or removal of explicit api_client_id query param
  • needs decision: correct server response for user not-found case

@yk
Copy link
Collaborator

yk commented Jan 10, 2023

looks good to me, I'll leave approval to @andreaskoepf

@olliestanley olliestanley enabled auto-merge (squash) January 10, 2023 10:55
andreaskoepf
andreaskoepf approved these changes Jan 10, 2023
View reviewed changes
Copy link
Collaborator

@andreaskoepf andreaskoepf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, let's merge!

@olliestanley olliestanley merged commit e5abb2d into LAION-AI:main Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yk yk yk left review comments

@nil-andreu nil-andreu nil-andreu left review comments

@andreaskoepf andreaskoepf andreaskoepf approved these changes

Assignees
No one assigned
Labels
backend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Endpoint to resolve frontend user by auth method and username
4 participants
@olliestanley @yk @andreaskoepf @nil-andreu