Use hooks for "create" tasks #550
Conversation
AbdBarho
requested review from
fozziethebeat and
k-nearest-neighbor
as code owners
AbdBarho
force-pushed
the
use-hooks-create
branch
from
130bd08 to
ad91bfe
Compare
| @@ -26,10 +26,10 @@ export const useGenericTaskAPI = <TaskType,>(taskApiEndpoint: string) => { | |||
| ); | |||
|
|
|||
| useEffect(() => { | |||
| if (tasks.length === 0 && !isLoading && !error) { | |||
| if (data === undefined && !isLoading && !error) { | |||
There was a problem hiding this comment.
Seems that change to undefined broke fix #393.
There was a problem hiding this comment.
oh, how to reproduce?
EDIT: got iit
There was a problem hiding this comment.
should be fixed now, could you please check again?
There was a problem hiding this comment.
Hmm. It's working 90% of the time. But when rapidly navigating it seems broken.
There was a problem hiding this comment.
Maybe we should leave the check as it was? And wait for #551 to solve it?
There was a problem hiding this comment.
I reduced the dedupe time to half a second, which should be reasonable.
#551 might solve this entirely, I don't know if we should squeeze it before MVP.
There was a problem hiding this comment.
Let's get the random task change done then we can switch to getServerSideProps. That can be rolled out anytime.
clean up code.
The same should be done for evaluate tasks.