Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

website: Refactor remaining task pages to use Task.tsx #591

Merged
merged 1 commit into from
Jan 10, 2023

Conversation

othrayte
Copy link
Collaborator

This changes the labeling tasks to use Task.tsx to reduce duplication and differing implementations.

Note: I had some issues with submitting the labeling tasks as I we get an error and don't handle it very well. I'm still trying to verify if that is something I added or was already there.

@fozziethebeat
Copy link
Collaborator

I see Yannic is fast on the labeling effort. Will review once the checks complete.

Copy link
Collaborator

@fozziethebeat fozziethebeat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see anything that would introduce a new submission error. I can try to replicate said error later.

@fozziethebeat
Copy link
Collaborator

Verified submission failure is not from these changes.

@fozziethebeat fozziethebeat merged commit d4e8759 into LAION-AI:main Jan 10, 2023
@othrayte othrayte deleted the refactor-task-pages branch January 10, 2023 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants