Encapsulate valid label fetching to FlaggableElement
#593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… from that within FlaggableElement. This allows FlaggableElement to fetch all its own data and remove the need to pipe labels through a series of components
|
Blocking on #590 before marking ready for review so I can merge. |
fozziethebeat
requested review from
k-nearest-neighbor and
AbdBarho
as code owners
|
I see code 422 (unprocessable entity) responses when submitting the label report on the rank pages, is this expected? Also I get the same on the labeling pages (but I'm not sure is we are planning to have the flags there). |
|
Good catch, I didn't catch that. Fixed now |
|
Posted #614 as a future cleanup around messages. The types are pretty confusing and different depending on use case. |
AbdBarho
reviewed
Jan 11, 2023
| import { oasstApiClient } from "src/lib/oasst_api_client"; | ||
|
|
||
| /** | ||
| * TODO |
There was a problem hiding this comment.
I see you did the review carefully. TODO was to write the handler comments. done :)
| /** | ||
| * TODO | ||
| */ | ||
| const handler = async (req, res) => { |
There was a problem hiding this comment.
can we use one of the middlewares here?
AbdBarho
approved these changes
Jan 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #584
This creates a new api route
/api/valid_labelsthat returns the list of valid labels that can apply to any message.FlaggableElementis updated to dynamically fetch labels from the new route and cache them. This allowsFlaggableElementto be used anywhere without needing to pipe in the valid labels from call sites. This still calls the api route once per page load.