Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gitignore venv #596

Merged
merged 21 commits into from
Jan 10, 2023
Merged

Gitignore venv #596

merged 21 commits into from
Jan 10, 2023

Conversation

andrewm4894
Copy link
Collaborator

@andrewm4894 andrewm4894 commented Jan 10, 2023 •
edited
Loading

i think its common enough for people to do

python -m venv venv

So adding venv to .gitignore in addition to just .venv will help avoid anyone (like me maybe :) ) committing whole venv as part of a PR :)

Is in default python .gitignore too here

yk
yk approved these changes Jan 10, 2023
View reviewed changes
Copy link
Collaborator

@yk yk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@yk yk merged commit 1318c21 into LAION-AI:main Jan 10, 2023
@andrewm4894 andrewm4894 deleted the gitignore-venv branch January 10, 2023 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yk yk yk approved these changes

@andreaskoepf andreaskoepf Awaiting requested review from andreaskoepf andreaskoepf is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrewm4894 @yk