website: Unify task controls #598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also happens to fix some issues with the no-changes are-you-sure dialog only appearing once and other form values not being reset correctly.
othrayte
requested review from
fozziethebeat,
k-nearest-neighbor and
AbdBarho
as code owners
| break; | ||
| case "SUBMITABLE": { | ||
| trigger({ | ||
| id: task.id, |
There was a problem hiding this comment.
This breaks things. task.id isn't the frontend ID it's the backend ID. Right now we can't do a guaranteed lookup to find the proper backend ID.
Once the backend changes remove the frontend ID this will be correct but as of right now submissions are broken.
There was a problem hiding this comment.
Ah, right. I can look into fixing it in about 5hrs, or do you want to fix it before then?
There was a problem hiding this comment.
I've got my fix up and ready :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unify the TaskControls implementation into one place.
Also happens to fix some issues with the no-changes are-you-sure dialog only appearing once and other form values not being reset correctly for new tasks etc.
This one ended up touching more code that I was originally hoping for, but I think it at least leaves everything in a better state.
This is the second PR for #569, if there is a third that would be to change the summarisation task pages to use Task.tsx.