Devcontainer backend dev #608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 10, 2023
Closed
nil-andreu
reviewed
Jan 11, 2023
| @@ -6,7 +6,7 @@ | |||
| "version": "latest" | |||
| } | |||
| }, | |||
| "postCreateCommand": "bash .devcontainer/frontend/post_create_command.sh", | |||
| "postCreateCommand": "bash .devcontainer/backend-dev/post_create_command.sh", | |||
There was a problem hiding this comment.
Why are we renaming this file?
Just a doubt, best of intentions.
There was a problem hiding this comment.
Just to be a little more consistent or inline with naming conventions in here. https://github.com/LAION-AI/Open-Assistant/blob/main/docker-compose.yaml
And try minimize any risk of someone confusing it with maybe some more prod ready "backend" devcontainer that maybe we could end up wanting to make in future.
There was a problem hiding this comment.
Oh the commit above is a relative path that needed to change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backend-devdevcontainer in.devcontainer/backend-dev.devcontainer/backend-dev/post_create_command.shto try automate some of the set up steps from backend/README.mdopenapi.jsonfrom local running fastapiwget localhost:8080/api/v1/openapi.json -O docs/docs/api/openapi.jsonto save openapi.json todocs/docs/api/You can see example of the openapi.json here from my branch: https://editor.swagger.io/?url=https://raw.githubusercontent.com/andrewm4894/Open-Assistant/devcontainer-backend-dev/docs/docs/api/openapi.json
unfortunately its still manual for now but am sure we can try automate the production of
docs/docs/api/openapi.jsonmaybe via a GH action at some stage.