Continuing #576 #619
Merged
Continuing #576 #619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanagno
reviewed
Jan 11, 2023
Comment on lines
+97
to
+98
| parser.add_argument("--poly_eps", type=float, default=1.0) | ||
| parser.add_argument("--seq2seq_model", action="store_true") |
There was a problem hiding this comment.
I would add these to the config files
There was a problem hiding this comment.
I would add these to the config files
Yes, normally it was but because of the file problems I had, it seems like that part was not updated.
sanagno
reviewed
Jan 11, 2023
| metrics, preprocess_fn = [evaluate.load("squad_v2")], preprocess_qa | ||
| elif any(dataset in summarization_datasets for dataset in conf.datasets): | ||
| metrics, preprocess_fn = [evaluate.load("rouge")], partial( | ||
| preprocess_summarization, tokenizer, ignore_pad_token_for_loss=conf.ignore_pad_token_for_loss |
There was a problem hiding this comment.
Is ignore_pad_token_for_loss defined in the config?
There was a problem hiding this comment.
Is ignore_pad_token_for_loss defined in the config?
It is one of the default arguments of huggingface trainer, so I thought it would be in the config.
sanagno
reviewed
Jan 11, 2023
| bitsandbytes.optim.GlobalOptimManager.get_instance().register_module_override( | ||
| module, "weight", {"optim_bits": 32} | ||
| ) | ||
| metrics, preprocess_fn = get_metrics(training_conf) |
There was a problem hiding this comment.
I am not sure these are used.
This was referenced Jan 11, 2023
Merged
theblackcat102
added a commit
that referenced
this pull request
Jan 12, 2023
Changes on #619. Datasets is getting a bit dirty. I will do a refactoring this week.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see.