Update the web to match the backends new API #622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…beling task works
fozziethebeat
requested review from
k-nearest-neighbor and
AbdBarho
as code owners
AbdBarho
reviewed
Jan 11, 2023
website/src/pages/tasks/random.tsx
Outdated
Comment on lines
11
to
15
| useEffect(() => { | ||
| if (tasks.length == 0) { | ||
| if (tasks.length === 0) { | ||
| reset(); | ||
| } | ||
| }, [tasks]); | ||
| }, [tasks, reset]); |
There was a problem hiding this comment.
is this useEffect necessary?
|
Note: the failing end2end tests is expected with the random update. #623 requests a fix for this. |
AbdBarho
approved these changes
Jan 11, 2023
|
I will merge with the hope of having a fix for #623 soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #616
The backend now expects a
task_idfield when calling/api/v1/interactionwhich matches the backend's task ID. The backend currently only requires this for labeling tasks but soon will require it for all tasks. This forwards that for all interaction types.Also, this fixes the labeling tasks by ensuring that
sliderValuesis always set properly.