Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add some "paths" to test-api-contract.yaml #630

Conversation

andrewm4894
Copy link
Collaborator

It seems to maybe be running a lot of the time.

A starter PR for this issue: #627

@andrewm4894 andrewm4894 marked this pull request as ready for review January 11, 2023 14:23
@andrewm4894 andrewm4894 enabled auto-merge (squash) January 11, 2023 14:24
@andrewm4894 andrewm4894 added backend testing all things testing labels Jan 11, 2023
@github-actions
Copy link

pre-commit failed.
Please run pre-commit run --all-files locally and commit the changes.
Find more information in the repository's CONTRIBUTING.md

@andrewm4894 andrewm4894 marked this pull request as draft January 11, 2023 14:42
auto-merge was automatically disabled January 11, 2023 14:42

Pull request was converted to draft

@andrewm4894 andrewm4894 marked this pull request as ready for review January 11, 2023 14:49
@andrewm4894 andrewm4894 enabled auto-merge (squash) January 11, 2023 14:50
@yk
Copy link
Collaborator

yk commented Jan 11, 2023

I'd rather include than exclude.
also, the same paths need to go into the pull request even

@andrewm4894
Copy link
Collaborator Author

I'd rather include than exclude. also, the same paths need to go into the pull request even

yeah - was just a bit unsure what paths we should use for include - any idea? i can rejig as needed if someone can give me a quick list.

@andrewm4894
Copy link
Collaborator Author

Actually looking at the workflow itself it looks like maybe its just

  • oasst-shared/**
  • backend/**
  • website/**

but was just hesitant in case can be some other dependencies im not aware of

@andrewm4894 andrewm4894 changed the title add some ignore paths to test-api-contract.yaml add some "paths" to test-api-contract.yaml Jan 11, 2023
Copy link
Collaborator

@yk yk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, this looks good, thank you :)

@andrewm4894 andrewm4894 merged commit d1e8df3 into LAION-AI:main Jan 11, 2023
@andrewm4894 andrewm4894 deleted the add-paths-ignore-to-test-api-contract-workflow branch January 11, 2023 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend testing all things testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants